X64 LGTM
http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc File src/x64/builtins-x64.cc (right): http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode661 src/x64/builtins-x64.cc:661: // Do not transform the receiver for natives (shared already in ebx). More verbose comments: (SharedFunctionInfo is already loaded into rbx). http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode663 src/x64/builtins-x64.cc:663: __ CompareRoot(rbx, Heap::kUndefinedValueRootIndex); Create a bug for handling non-native functions with undefined script. http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode666 src/x64/builtins-x64.cc:666: __ SmiToInteger32(rbx, rbx); Use __ SmiToInteger32(rbx, FieldOperand(rbx, Script::kTypeOffset)) to load an integer32 from a smi memory location. Or better yet, use SmiCompare(FieldOperand(rbx, Script::kTypeOffset), Smi::FromInt(Script::TYPE_NATIVE)); to compare directly with memory. http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode667 src/x64/builtins-x64.cc:667: __ cmpq(rbx, Immediate(Script::TYPE_NATIVE)); Should have been cmpl. http://codereview.chromium.org/6928007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
