drive-by comment.
http://codereview.chromium.org/6894003/diff/43002/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/6894003/diff/43002/src/x64/stub-cache-x64.cc#newcode2538 src/x64/stub-cache-x64.cc:2538: Handle<Code>(handler_ics->at(current)), You repeatedly read the map out of the value. It'll obviously be hot, so the memory compare should be quick. Still, would it be possible to find a scratch register and read the map once, before the checks, and only do register compares? It would save one byte per compare, at the cost of one memory load (~4 bytes IIRC). http://codereview.chromium.org/6894003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
