Thanks! Landing.
http://codereview.chromium.org/7000023/diff/1/src/ia32/macro-assembler-ia32-inl.h File src/ia32/macro-assembler-ia32-inl.h (right): http://codereview.chromium.org/7000023/diff/1/src/ia32/macro-assembler-ia32-inl.h#newcode43 src/ia32/macro-assembler-ia32-inl.h:43: LabelType* not_set) { On 2011/05/11 18:53:57, Erik Corry wrote:
not_set seems like the wrong name, since it means is_set if the
condition is
not_zero. How about condition_met?
Done. http://codereview.chromium.org/7000023/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/7000023/diff/1/src/ia32/macro-assembler-ia32.cc#newcode241 src/ia32/macro-assembler-ia32.cc:241: value, On 2011/05/11 18:53:57, Erik Corry wrote:
Add comment that value is used as scratch here.
Done. http://codereview.chromium.org/7000023/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): http://codereview.chromium.org/7000023/diff/1/src/incremental-marking.cc#newcode165 src/incremental-marking.cc:165: void IncrementalMarking::RevertWriteBarrierFlags(PagedSpace* space) { On 2011/05/11 18:53:57, Erik Corry wrote:
Revert doesn't convey a lot of meaning to me. Reverting from what to
what? How
about "DeactivateIncrementalWriteBarrier"?
Done. http://codereview.chromium.org/7000023/diff/1/src/spaces-inl.h File src/spaces-inl.h (right): http://codereview.chromium.org/7000023/diff/1/src/spaces-inl.h#newcode278 src/spaces-inl.h:278: // TODO(gc) ISOLATESMERGE initialize chunk to point to heap? On 2011/05/11 18:53:57, Erik Corry wrote:
I don't see how we can defer this to a TODO. We have GetHeap that
works on any
HeapObject. This will fail if we get a large object.
Done. http://codereview.chromium.org/7000023/diff/1/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/7000023/diff/1/src/spaces.h#newcode370 src/spaces.h:370: CONTAINS_INTERESTING_DESTINATIONS, On 2011/05/11 18:53:57, Erik Corry wrote:
I don't like these names. If a pointer points from one object to
another how
can the destination be the 'from' object.
How about POINTERS_FROM_HERE_ARE_INTERESTING and POINTERS_TO_HERE_ARE_INTERESTING
Done. http://codereview.chromium.org/7000023/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
