Reviewers: Jungshik Shin, Mads Ager,

http://codereview.chromium.org/7014019/diff/5002/src/extensions/experimental/datetime-format.cc
File src/extensions/experimental/datetime-format.cc (right):

http://codereview.chromium.org/7014019/diff/5002/src/extensions/experimental/datetime-format.cc#newcode80
src/extensions/experimental/datetime-format.cc:80: ->NumberValue();
Mads: Is this a good way to get current date? The v8::Date::New requires
double to create new Date so I had to actually invoke JS script to do
it.

Description:
Adding DateTimeFormat class to i18n API with following methods:

- format
- getWeekdays
- getMonths
- get Eras
- getAmPm

TEST=Visit i18n.kaziprst.org/datetimeformat.html

Please review this at http://codereview.chromium.org/7014019/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  A     src/extensions/experimental/datetime-format.h
  A     src/extensions/experimental/datetime-format.cc
  M     src/extensions/experimental/experimental.gyp
  M     src/extensions/experimental/i18n-extension.cc
  M     src/extensions/experimental/i18n-utils.h
  M     src/extensions/experimental/i18n-utils.cc
  M     src/extensions/experimental/i18n.js


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to