LGTM! The lua parts really should be written in python though.
http://codereview.chromium.org/6973063/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): http://codereview.chromium.org/6973063/diff/1/src/bootstrapper.cc#newcode1728 src/bootstrapper.cc:1728: #define F(size, func) do { \ Restore alignment of '\' http://codereview.chromium.org/6973063/diff/1/tools/gcmole/Makefile File tools/gcmole/Makefile (right): http://codereview.chromium.org/6973063/diff/1/tools/gcmole/Makefile#newcode35 tools/gcmole/Makefile:35: -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -03 \ Accidental edit? http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc File tools/gcmole/gcmole.cc (right): http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode98 tools/gcmole/gcmole.cc:98: e = result.second; How about extracting result.second before the loop to get saner indentation? http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode350 tools/gcmole/gcmole.cc:350: i != end; Move envs_.end() here to make code more readable? http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode363 tools/gcmole/gcmole.cc:363: i != end; Ditto. Also multiple places below. http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode506 tools/gcmole/gcmole.cc:506: clang::type * concrete_expr = dyn_cast_or_null<clang::type>(expr); \ Placement of '*'. http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode882 tools/gcmole/gcmole.cc:882: Environment Visit##type (clang::type * stmt, const Environment& env) Is there a reason for the '*' placement here and in the line below? http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode885 tools/gcmole/gcmole.cc:885: Environment Visit##type (clang::type * stmt, const Environment& env) { \ If you place the '*' differently the '\' aligns with the rest. http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode905 tools/gcmole/gcmole.cc:905: : in_(in), out_(Environment::Unreachable()), changed_(false), owner_(owner) { Long line. http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode1012 tools/gcmole/gcmole.cc:1012: block.Loop(stmt->getCond(), Shouldn't this be Loop(Cond, Body, Inc)? http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.cc#newcode1188 tools/gcmole/gcmole.cc:1188: clang::CXXRecordDecl* smiDecl = Why the switch in naming conventions? smi_decl and object_decl? http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.lua File tools/gcmole/gcmole.lua (right): http://codereview.chromium.org/6973063/diff/1/tools/gcmole/gcmole.lua#newcode60 tools/gcmole/gcmole.lua:60: FLAGS[flag] = (no ~= "no") Tabs in the file. Here and later. http://codereview.chromium.org/6973063/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
