LGTM, with comments addressed I like the simplifications!
http://codereview.chromium.org/7021007/diff/6002/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/7021007/diff/6002/src/arm/lithium-codegen-arm.cc#newcode263 src/arm/lithium-codegen-arm.cc:263: // Each entry in the jump table generates only one instruction. I have not been able to find anywhere where we ensure that this assert holds. We do try to not crankshaft compile large functions, so most likely this will never happen. However I find that it will be better to just abort the crankshaft compilation if this ever happens. That should mark the function as not-optimizable, and we will not try to crankshaft compile it again. http://codereview.chromium.org/7021007/diff/6002/src/arm/lithium-codegen-arm.cc#newcode625 src/arm/lithium-codegen-arm.cc:625: if (FLAG_trap_on_deopt) __ stop("trap_on_deopt"); Shouldn't this stop still be conditional if cc is not al? http://codereview.chromium.org/7021007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
