http://codereview.chromium.org/7029030/diff/1/src/heap-inl.h File src/heap-inl.h (right):
http://codereview.chromium.org/7029030/diff/1/src/heap-inl.h#newcode257 src/heap-inl.h:257: bool result = new_space_.PageContains(object); That is the idea. If anything, this name is a little too nice. It should stand out like a sore thumb, kindof like C++ casts. http://codereview.chromium.org/7029030/diff/1/src/ia32/macro-assembler-ia32-inl.h File src/ia32/macro-assembler-ia32-inl.h (right): http://codereview.chromium.org/7029030/diff/1/src/ia32/macro-assembler-ia32-inl.h#newcode37 src/ia32/macro-assembler-ia32-inl.h:37: void MacroAssembler::InNewSpace(Register object, Merged this with CheckPageFlag (accept object and scratch being the same register, use byte test). http://codereview.chromium.org/7029030/diff/1/src/objects.h File src/objects.h (right): http://codereview.chromium.org/7029030/diff/1/src/objects.h#newcode634 src/objects.h:634: class Failure; Done. http://codereview.chromium.org/7029030/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7029030/diff/1/src/runtime.cc#newcode595 src/runtime.cc:595: if (value->IsFailure()) { OS::DebugBreak(); } Ack, yes. Shouldn't happen any more. I'll keep the assert (it's on bleeding edge too). http://codereview.chromium.org/7029030/diff/1/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/7029030/diff/1/src/spaces.h#newcode1698 src/spaces.h:1698: // page, it must be a pointer into the beginning of it. Moved. http://codereview.chromium.org/7029030/diff/1/src/spaces.h#newcode1708 src/spaces.h:1708: return false; Done. http://codereview.chromium.org/7029030/diff/1/src/spaces.h#newcode1719 src/spaces.h:1719: if ((reinterpret_cast<uintptr_t>(o) & ~kHeapObjectTagMask) == And done. http://codereview.chromium.org/7029030/diff/1/src/store-buffer.cc File src/store-buffer.cc (right): http://codereview.chromium.org/7029030/diff/1/src/store-buffer.cc#newcode420 src/store-buffer.cc:420: (owner == page->heap()->map_space() ? On 2011/05/19 07:22:32, Erik Corry wrote:
page->heap() could just be heap_
Done. http://codereview.chromium.org/7029030/diff/1/src/top.cc File src/top.cc (right): http://codereview.chromium.org/7029030/diff/1/src/top.cc#newcode575 src/top.cc:575: if (exception->IsFailure()) return exception->ToFailureUnchecked(); Already ported to bleeding edge (or actually, from bleeding_edge). Will check branches. http://codereview.chromium.org/7029030/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
