On 2011/05/19 11:31:01, Vitaly Repeshko wrote:
http://codereview.chromium.org/7046001/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
http://codereview.chromium.org/7046001/diff/1/test/cctest/test-cpu-profiler.cc#newcode250
test/cctest/test-cpu-profiler.cc:250: while (!processor.running()) {
ProfilerEventsProcessor sets "running" to true in the constructor. Do we
need
this loop (here and in other places in this file)? If yes, can we replace
it
with a semaphore?
Good catch!
No, we don't need it. Initially ProfilerEventsProcessor was setting it
to 'true'
later (in the Run method), and the test code I've copied was written at that
time.
I will clean this up.
http://codereview.chromium.org/7046001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
