Comments addressed
http://codereview.chromium.org/7067017/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): http://codereview.chromium.org/7067017/diff/1/src/bootstrapper.cc#newcode557 src/bootstrapper.cc:557: factory()->NewFunctionWithoutPrototype(name, kStrictMode); On 2011/05/24 09:44:10, Lasse Reichstein wrote:
It's should not be a strict function. If it's a strict function, it throws if you do func.arguments. It
shouldn't for
builtin functions.
Done http://codereview.chromium.org/7067017/diff/1/src/bootstrapper.cc#newcode557 src/bootstrapper.cc:557: factory()->NewFunctionWithoutPrototype(name, kStrictMode); On 2011/05/24 09:44:10, Lasse Reichstein wrote:
Does this create a function with no .prototype property? It seems to
have a
.prototype property if you check in the current version.
It creates an empty function with a function without a prototype as prototype (you might have to read that line a few times) http://codereview.chromium.org/7067017/diff/1/src/bootstrapper.cc#newcode560 src/bootstrapper.cc:560: Builtins::kStrictModePoisonPill)); On 2011/05/24 09:44:10, Lasse Reichstein wrote:
Just use an initializer instead of repeating "Handle<Code>": Handle<Code> code(isolate()-> ...);
Done. http://codereview.chromium.org/7067017/diff/1/src/bootstrapper.cc#newcode563 src/bootstrapper.cc:563: global_context()->strict_mode_function_map()); On 2011/05/24 09:44:10, Lasse Reichstein wrote:
Still not a strict function.
Done. http://codereview.chromium.org/7067017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
