LGTM with style/indentation fixed.
http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode1710 src/arm/code-stubs-arm.cc:1710: Handle<Code> GetUnaryOpStub(int key, Indentation. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode1810 src/arm/code-stubs-arm.cc:1810: void UnaryOpStub::GenerateSmiCodeSub(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode1825 src/arm/code-stubs-arm.cc:1825: void UnaryOpStub::GenerateSmiCodeBitNot(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode1863 src/arm/code-stubs-arm.cc:1863: void UnaryOpStub::GenerateHeapNumberStubBitNot( Fits on one line? http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode1873 src/arm/code-stubs-arm.cc:1873: void UnaryOpStub::GenerateHeapNumberCodeSub(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode1991 src/arm/code-stubs-arm.cc:1991: void UnaryOpStub::GenerateGenericCodeFallback( Fits on one line? http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode2008 src/arm/code-stubs-arm.cc:2008: Handle<Code> GetBinaryOpStub(int key, Full indentation (not 4 spaces) or int key on a separate line. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode2096 src/arm/code-stubs-arm.cc:2096: void BinaryOpStub::GenerateSmiSmiOperation( Fits one line? http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode2222 src/arm/code-stubs-arm.cc:2222: void BinaryOpStub::GenerateFPOperation(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode2436 src/arm/code-stubs-arm.cc:2436: void BinaryOpStub::GenerateSmiCode(MacroAssembler* masm, MacroAssembler* masm, should go on a separate line. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode2766 src/arm/code-stubs-arm.cc:2766: (result_type_ <= BinaryOpIC::INT32) ? &transition Indentation. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode2769 src/arm/code-stubs-arm.cc:2769: __ b(mi, (result_type_ <= BinaryOpIC::INT32) ? &transition Indentation. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode2972 src/arm/code-stubs-arm.cc:2972: void BinaryOpStub::GenerateHeapResultAllocation( Fits full indentation. http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#newcode520 src/ia32/code-stubs-ia32.cc:520: Handle<Code> GetUnaryOpStub(int key, Indentation. http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#newcode623 src/ia32/code-stubs-ia32.cc:623: void UnaryOpStub::GenerateSmiCodeSub(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#newcode707 src/ia32/code-stubs-ia32.cc:707: void UnaryOpStub::GenerateHeapNumberCodeSub(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#newcode743 src/ia32/code-stubs-ia32.cc:743: void UnaryOpStub::GenerateHeapNumberCodeBitNot( Move MacroAssembler* masm, up one line and full indent of Label* slow? http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#newcode840 src/ia32/code-stubs-ia32.cc:840: void UnaryOpStub::GenerateGenericCodeFallback( Fits one line? http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#newcode892 src/ia32/code-stubs-ia32.cc:892: void BinaryOpStub::GenerateTypeTransitionWithSavedArgs( Fits one line? http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#newcode970 src/ia32/code-stubs-ia32.cc:970: void BinaryOpStub::GenerateSmiCode(MacroAssembler* masm, MacroAssembler* masm, on a separate line http://codereview.chromium.org/7063017/diff/1/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/7063017/diff/1/src/ic.cc#newcode2203 src/ic.cc:2203: UnaryOpIC::TypeInfo UnaryOpIC::ComputeNewType( Possibly reorganize arguments. http://codereview.chromium.org/7063017/diff/1/src/ic.cc#newcode2264 src/ic.cc:2264: BinaryOpIC::TypeInfo BinaryOpIC::JoinTypes(BinaryOpIC::TypeInfo x, Indentation. http://codereview.chromium.org/7063017/diff/1/src/ic.cc#newcode2279 src/ic.cc:2279: BinaryOpIC::TypeInfo BinaryOpIC::GetTypeInfo(Handle<Object> left, Indentation. http://codereview.chromium.org/7063017/diff/1/src/ic.cc#newcode2373 src/ic.cc:2373: Handle<Code> GetBinaryOpStub(int key, Indentation. http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode1907 src/mips/code-stubs-mips.cc:1907: void UnaryOpStub::GenerateSmiCodeSub(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode1922 src/mips/code-stubs-mips.cc:1922: void UnaryOpStub::GenerateSmiCodeBitNot(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode1960 src/mips/code-stubs-mips.cc:1960: void UnaryOpStub::GenerateHeapNumberStubBitNot( Fits one line? http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode1970 src/mips/code-stubs-mips.cc:1970: void UnaryOpStub::GenerateHeapNumberCodeSub(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode2003 src/mips/code-stubs-mips.cc:2003: void UnaryOpStub::GenerateHeapNumberCodeBitNot( Reorganize arguments? http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode2104 src/mips/code-stubs-mips.cc:2104: Handle<Code> GetBinaryOpStub(int key, Full indentation or int key on separate line. http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode2193 src/mips/code-stubs-mips.cc:2193: void BinaryOpStub::GenerateSmiSmiOperation( Fits one line? http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode2348 src/mips/code-stubs-mips.cc:2348: void BinaryOpStub::GenerateFPOperation(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#newcode2564 src/mips/code-stubs-mips.cc:2564: void BinaryOpStub::GenerateSmiCode(MacroAssembler* masm, MacroAssembler* masm, on separate line. http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode409 src/x64/code-stubs-x64.cc:409: Handle<Code> GetUnaryOpStub(int key, Indentation. http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode487 src/x64/code-stubs-x64.cc:487: void UnaryOpStub::GenerateSmiCodeSub(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode501 src/x64/code-stubs-x64.cc:501: void UnaryOpStub::GenerateSmiCodeBitNot( Fits full intentation? http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode549 src/x64/code-stubs-x64.cc:549: void UnaryOpStub::GenerateHeapNumberCodeSub(MacroAssembler* masm, Indentation. http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode590 src/x64/code-stubs-x64.cc:590: void UnaryOpStub::GenerateHeapNumberCodeBitNot( Fits full indentation? http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode643 src/x64/code-stubs-x64.cc:643: void UnaryOpStub::GenerateGenericCodeFallback( Fits one line? http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode684 src/x64/code-stubs-x64.cc:684: Handle<Code> GetBinaryOpStub(int key, Full intentation or int key on separate line. http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode773 src/x64/code-stubs-x64.cc:773: void BinaryOpStub::GenerateSmiCode(MacroAssembler* masm, MacroAssembler* masm, on separate line. http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode923 src/x64/code-stubs-x64.cc:923: void BinaryOpStub::GenerateFloatingPointCode( Fits full indentation? http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newcode1228 src/x64/code-stubs-x64.cc:1228: void BinaryOpStub::GenerateHeapResultAllocation( Fits full indentation? http://codereview.chromium.org/7063017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
