Still LGTM
http://codereview.chromium.org/7067019/diff/1/src/builtins.cc File src/builtins.cc (right): http://codereview.chromium.org/7067019/diff/1/src/builtins.cc#newcode379 src/builtins.cc:379: if (array_proto != global_context->initial_object_prototype()) return false; Sorry, I mean JSObject::cast and != global_context->initial_object_prototype() check. But if don't allow anything except for null and JSObject as a prototype value, then it's not mandatory. On 2011/05/24 12:25:52, Søren Gjesse wrote:
On 2011/05/24 10:38:20, antonm wrote: > while you're here, may you swap these two lines? I am concerned
with the
> following case: Array.prototype.__proto__ = 2;
Not sure which two lines you mean. Also
Array.prototype.__proto__ = 2
does not have any effect.
http://codereview.chromium.org/7067019/diff/3002/src/builtins.cc#newcode369 src/builtins.cc:369: // This method depends on non writability of Object and Array prototype just fyi, this comment is still here http://codereview.chromium.org/7067019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
