I like it. Seems to be much cleaner then before (especially because there
is no
free/deallocated duality).
I am a bit concerned about fragmentation which might negatively affect
iteration
performance though.
http://codereview.chromium.org/6992025/diff/1/src/global-handles.cc
File src/global-handles.cc (right):
http://codereview.chromium.org/6992025/diff/1/src/global-handles.cc#newcode397
src/global-handles.cc:397: new NodeBlock(this);
Personally I don't like constructors with deep implicit side effects.
http://codereview.chromium.org/6992025/diff/1/src/global-handles.cc#newcode510
src/global-handles.cc:510: if (collector == SCAVENGER &&
!it.node()->is_independent()) continue;
Interesting: so skipping blocks with no young independent handles here
does not win us anything, does it?
http://codereview.chromium.org/6992025/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
