Reviewers: Rico,
Description:
Fix a number of tests that incorrectly used assertUnreachable.
Our testing infrastructure uses exceptions to indicate
errors. assertUnreachable therefore throws an exception to indicate
that it was reached. Therefore, it cannot be used to check that an
exception was thrown using the pattern:
try {
shouldThrow();
assertUnreachable();
} catch(e) {
}
Such a test will always pass because assertUnreachable will throw an
exception if shouldThrow does not.
[email protected]
Please review this at http://codereview.chromium.org/7053035/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/mjsunit/array-reduce.js
M test/mjsunit/function-call.js
M test/mjsunit/object-define-property.js
M test/mjsunit/object-freeze.js
M test/mjsunit/object-literal.js
M test/mjsunit/object-seal.js
M test/mjsunit/property-load-across-eval.js
M test/mjsunit/regress/regress-1119.js
M test/mjsunit/regress/regress-1130.js
M test/mjsunit/regress/regress-1132.js
M test/mjsunit/regress/regress-1160.js
M test/mjsunit/regress/regress-1170.js
M test/mjsunit/regress/regress-1172-bis.js
M test/mjsunit/regress/regress-1327557.js
M test/mjsunit/regress/regress-244.js
M test/mjsunit/strict-mode-eval.js
M test/mjsunit/strict-mode.js
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
