Reviewers: Dmitry Lomov (chromium),
Description:
Fix building with gdbjit=on (add missing isolate pointer parameter).
Fix a warning in liveedit.cc (signed/unsigned mismatch).
BUG=
TEST=
Please review this at http://codereview.chromium.org/7101011/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M src/gdb-jit.cc
M src/liveedit.cc
Index: src/gdb-jit.cc
diff --git a/src/gdb-jit.cc b/src/gdb-jit.cc
index
bf8ac19fb86aa27afc3eb78ddddf50d8d876cd72..df7a5a055b64cfbd5ba784e1ea09a6ff0d139133
100644
--- a/src/gdb-jit.cc
+++ b/src/gdb-jit.cc
@@ -1327,7 +1327,7 @@ static void UnregisterCodeEntry(JITCodeEntry* entry) {
static JITCodeEntry* CreateELFObject(CodeDescription* desc) {
- ZoneScope zone_scope(DELETE_ON_EXIT);
+ ZoneScope zone_scope(Isolate::Current(), DELETE_ON_EXIT);
ELF elf;
Writer w(&elf);
Index: src/liveedit.cc
diff --git a/src/liveedit.cc b/src/liveedit.cc
index
def212f63767dd1b0d116d5cf7c351f6d0334c47..bc73445319faa614a4b233838b1c6ef4c531b090
100644
--- a/src/liveedit.cc
+++ b/src/liveedit.cc
@@ -93,8 +93,9 @@ class Differencer {
return;
}
multiply *= sizeof(int); // NOLINT
+ ASSERT(multiply >= 0);
size_t size = multiply;
- if (size != multiply) {
+ if (static_cast<int64_t>(size) != multiply) {
// Shouldn't be reachable.
ThrowStringException(
"Too many lines: "
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
