http://codereview.chromium.org/7066048/diff/7001/samples/shell.cc File samples/shell.cc (right):
http://codereview.chromium.org/7066048/diff/7001/samples/shell.cc#newcode312 samples/shell.cc:312: BZip2Decompressor startup_data_decompressor; It seems unfortunate that the shell sample is using something that looks like internal code to demonstrate the compression feature. Could you document that it's safe to use its implementation details? Or how about we expose a documented convenience API DecompressWithCallback? http://codereview.chromium.org/7066048/diff/7001/src/bz2-decompress.h File src/bz2-decompress.h (right): http://codereview.chromium.org/7066048/diff/7001/src/bz2-decompress.h#newcode31 src/bz2-decompress.h:31: class BZip2Decompressor { This should be some namespace and should be documented. http://codereview.chromium.org/7066048/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
