http://codereview.chromium.org/7122003/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/7122003/diff/1/src/x64/assembler-x64.h#newcode1378
src/x64/assembler-x64.h:1378: inline byte get_opcode(int offset) {
On 2011/06/08 10:58:46, Lasse Reichstein wrote:
The call site can make its own local functions by any name, which call
the
generic method on the assembler.
The generic method is there now, and public, for anyone to use at any
time.
For that reason alone, I think it should be less bound to the current
use-case.
E.g., I think it should take a zero-based index, not a pc-based index.
It's easy
to convert between the two (using pc_offset()).
Or, preferably, replace it with a macro like:
PatchableNearJump(byte opcode, Label* label) {
db(opcode);
emit_near_disp(label);
}
but there is a visibility issue to work around with that, since
MacroAssembler
cant see emit_near_disp. Perhaps make a db_near_disp(Label*) method
for that.
I now use set_byte_at and pc_offset instead.
http://codereview.chromium.org/7122003/diff/1/src/x64/assembler-x64.h#newcode1378
src/x64/assembler-x64.h:1378: inline byte get_opcode(int offset) {
On 2011/06/08 10:58:46, Lasse Reichstein wrote:
I don't see us using get_opcode anywhere. Just remove it.
It was used in an assert
http://codereview.chromium.org/7122003/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
