feedback addressed, landing...
http://codereview.chromium.org/7089002/diff/17001/src/factory.h File src/factory.h (right): http://codereview.chromium.org/7089002/diff/17001/src/factory.h#newcode52 src/factory.h:52: // Allocate a new fixed double array with undefined entries. On 2011/06/08 13:13:13, Mads Ager wrote:
Nit: Could you update the comment to use the wording: uninitialized
fixed double
array? And do the same for NewFixedArray above? I get confused by the
use of
undefined here (not sure if it means the 'undefined' value).
Done. http://codereview.chromium.org/7089002/diff/17001/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/7089002/diff/17001/src/heap.cc#newcode1310 src/heap.cc:1310: table_.Register(kVisitByteArray, &EvacuateByteArray); On 2011/06/08 12:31:16, Vyacheslav Egorov wrote:
If FixedDoubleArray can be in the new space you need to register
specialization
here.
Done. http://codereview.chromium.org/7089002/diff/17001/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/7089002/diff/17001/src/objects-inl.h#newcode1627 src/objects-inl.h:1627: ASSERT(map() != HEAP->fixed_cow_array_map()); On 2011/06/08 13:13:13, Mads Ager wrote:
If you assert for fixed_cow_array_map should you assert for normal fixed_array_map too?
Done. http://codereview.chromium.org/7089002/diff/17001/src/objects-inl.h#newcode1635 src/objects-inl.h:1635: ASSERT(map() != HEAP->fixed_cow_array_map()); On 2011/06/08 13:13:13, Mads Ager wrote:
Ditto?
Done. http://codereview.chromium.org/7089002/diff/17001/src/objects-visiting.h File src/objects-visiting.h (right): http://codereview.chromium.org/7089002/diff/17001/src/objects-visiting.h#newcode294 src/objects-visiting.h:294: table_.Register(kVisitByteArray, &VisitByteArray); On 2011/06/08 12:31:16, Vyacheslav Egorov wrote:
If FixedDoubleArray can be in a new space you need to register
specialization
here.
Done. http://codereview.chromium.org/7089002/diff/17001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/7089002/diff/17001/src/objects.cc#newcode8051 src/objects.cc:8051: // Check whether there is extra space in the fixed array.. On 2011/06/08 13:13:13, Mads Ager wrote:
.. -> .
Done. http://codereview.chromium.org/7089002/diff/17001/src/objects.cc#newcode8452 src/objects.cc:8452: return GetHeap()->AllocateHeapNumber(double_value); On 2011/06/08 13:13:13, Mads Ager wrote:
Use NumberFromDouble?
Done. http://codereview.chromium.org/7089002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
