LGTM.
http://codereview.chromium.org/7044049/diff/1017/src/arm/lithium-arm.h File src/arm/lithium-arm.h (right): http://codereview.chromium.org/7044049/diff/1017/src/arm/lithium-arm.h#newcode1664 src/arm/lithium-arm.h:1664: bool deoptimize_on_undefined() { return deoptimize_on_undefined_; } I think you can change this to { return hydrogen()->deoptimize_on_undefined(); } and declare a hydrogen() accessor. Then there is no need for an extra private data member. http://codereview.chromium.org/7044049/diff/1017/src/arm/lithium-arm.h#newcode1666 src/arm/lithium-arm.h:1666: DECLARE_CONCRETE_INSTRUCTION(NumberUntagD, "double-untag") Add DECLARE_HYDROGEN_ACCESSOR(Change) here. The same applies for the other platforms as well. http://codereview.chromium.org/7044049/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
