Reviewers: Lasse Reichstein,
Description:
Don't allocate handles for substrings when filling up the split result
array.
Please review this at http://codereview.chromium.org/7003083/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/runtime.cc
Index: src/runtime.cc
===================================================================
--- src/runtime.cc (revision 8234)
+++ src/runtime.cc (working copy)
@@ -5805,11 +5805,14 @@
Handle<FixedArray> elements(FixedArray::cast(result->elements()));
int part_start = 0;
for (int i = 0; i < part_count; i++) {
- HandleScope local_loop_handle;
int part_end = indices.at(i);
- Handle<String> substring =
- isolate->factory()->NewSubString(subject, part_start, part_end);
- elements->set(i, *substring);
+ Object* result;
+ { MaybeObject* maybe_result =
isolate->heap()->AllocateSubString(*subject,
+
part_start,
+
part_end);
+ if (!maybe_result->ToObject(&result)) return maybe_result;
+ }
+ elements->set(i, result);
part_start = part_end + pattern_length;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
