Reviewers: Mads Ager,

Message:
Please review.

Reviewer guidance:

Most of the changes are purely mechanical, However, there are two functionality
changes to keep an eye out for.

First, in the stub-cache* implementation files, the caching login for fast
elements and external elements has been merged.

Second, the ExternalArrayType doesn't need to get explicitly stashed away
out-of-band to preserve type information from the ICs, since the ElementKind is
stored directly in the map.

Description:
Dispatch on ElementsKind rather than ExternalArrayType when generating ICs and Crankshaft code for many element operations. This is preparation to be able to
share more code in the various element accessor implementations.

Merge logic to maintain external array and fast element stub caches.

BUG=none
TEST=none


Please review this at http://codereview.chromium.org/7112010/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/arm/lithium-arm.h
  M src/arm/lithium-arm.cc
  M src/arm/lithium-codegen-arm.cc
  M src/arm/stub-cache-arm.cc
  M src/ast.h
  M src/ast.cc
  M src/code-stubs.h
  M src/code-stubs.cc
  M src/heap.h
  M src/hydrogen-instructions.h
  M src/hydrogen-instructions.cc
  M src/hydrogen.cc
  M src/ia32/lithium-codegen-ia32.h
  M src/ia32/lithium-codegen-ia32.cc
  M src/ia32/lithium-ia32.h
  M src/ia32/lithium-ia32.cc
  M src/ia32/stub-cache-ia32.cc
  M src/ic.h
  M src/ic.cc
  M src/lithium.h
  M src/lithium.cc
  M src/objects-inl.h
  M src/objects.h
  M src/stub-cache.h
  M src/stub-cache.cc
  src/type-info.h
  M src/type-info.cc
  M src/x64/lithium-codegen-x64.h
  M src/x64/lithium-codegen-x64.cc
  M src/x64/lithium-x64.h
  M src/x64/lithium-x64.cc
  M src/x64/stub-cache-x64.cc


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to