Reviewers: Jungshik Shin, Mads Ager,
Message:
Jungshink: please take a look at ICU calls and overall logic.
Mads:
I can't use internal methods so I had to make some interesting choices on
how to
detect NaN in C++ code.
Could you take a look at JSNumberFormat method where I eval('NaN') to get
actual
value and see if it makes sense.
From some forum posts it seems v8 uses 2 values for NaN (-NaN and NaN).
True?
Description:
Adding support for number formating to the JS i18n API.
This is the last part of the API that belongs in public spec.
Methods supported:
- format
- derive
Options supported:
- style (decimal, scientific, currency and percent)
- pattern
- skeleton
TEST= Visit i18n.kaziprst.org/numberformat.html
Please review this at http://codereview.chromium.org/7129051/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/extensions/experimental/experimental.gyp
M src/extensions/experimental/i18n-extension.cc
M src/extensions/experimental/i18n.js
A src/extensions/experimental/number-format.h
A src/extensions/experimental/number-format.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev