"Deisolate" maybe? LGTM!
http://codereview.chromium.org/7003108/diff/1/include/v8.h File include/v8.h (right): http://codereview.chromium.org/7003108/diff/1/include/v8.h#newcode3095 include/v8.h:3095: * Is V8 terminating JavaScript execution. Please update the comment. http://codereview.chromium.org/7003108/diff/1/src/debug.cc File src/debug.cc (left): http://codereview.chromium.org/7003108/diff/1/src/debug.cc#oldcode799 src/debug.cc:799: ASSERT(Isolate::Current() == isolate_); Some of these asserts are useful as the isolate is not threaded through all the calls here. The parts of the interface that are required to work without the isolate being current should be clearly marked. Otherwise, we risk e.g. mixing isolate heaps. http://codereview.chromium.org/7003108/diff/1/src/debug.cc File src/debug.cc (right): http://codereview.chromium.org/7003108/diff/1/src/debug.cc#newcode2640 src/debug.cc:2640: isolate_->compilation_cache()->Disable(); As we discussed this is actually unsafe. ListenersChanged may be called from any thread and touches the compilation cache. This means we need a compilation cache mutex. Having the debugger mutex only doesn't seem to be enough. Please file a bug. http://codereview.chromium.org/7003108/diff/1/src/platform-openbsd.cc File src/platform-openbsd.cc (right): http://codereview.chromium.org/7003108/diff/1/src/platform-openbsd.cc#newcode399 src/platform-openbsd.cc:399: Thread::Thread(Isolate* isolate, const Options& options) Won't compile. http://codereview.chromium.org/7003108/diff/1/src/platform-openbsd.cc#newcode407 src/platform-openbsd.cc:407: Thread::Thread(Isolate* isolate, const char* name) Ditto. http://codereview.chromium.org/7003108/diff/1/src/platform-openbsd.cc#newcode427 src/platform-openbsd.cc:427: Thread::SetThreadLocal(Isolate::isolate_key(), thread->isolate()); Remove this line. http://codereview.chromium.org/7003108/diff/1/src/platform-solaris.cc File src/platform-solaris.cc (right): http://codereview.chromium.org/7003108/diff/1/src/platform-solaris.cc#newcode385 src/platform-solaris.cc:385: isolate_(isolate), Won't compile. http://codereview.chromium.org/7003108/diff/1/src/platform-solaris.cc#newcode391 src/platform-solaris.cc:391: Thread::Thread(Isolate* isolate, const char* name) Ditto. http://codereview.chromium.org/7003108/diff/1/src/platform-win32.cc File src/platform-win32.cc (right): http://codereview.chromium.org/7003108/diff/1/src/platform-win32.cc#newcode1479 src/platform-win32.cc:1479: Thread::SetThreadLocal(Isolate::isolate_key(), thread->isolate()); Remove this line. http://codereview.chromium.org/7003108/diff/1/src/platform-win32.cc#newcode1495 src/platform-win32.cc:1495: Thread::Thread(Isolate* isolate, const Options& options) Won't compile. http://codereview.chromium.org/7003108/diff/1/src/platform-win32.cc#newcode1503 src/platform-win32.cc:1503: Thread::Thread(Isolate* isolate, const char* name) Ditto. http://codereview.chromium.org/7003108/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
