http://codereview.chromium.org/7044104/diff/1/src/v8natives.js
File src/v8natives.js (right):
http://codereview.chromium.org/7044104/diff/1/src/v8natives.js#newcode942
src/v8natives.js:942: desc.setConfigurable(false);
On 2011/06/10 09:09:10, Lasse Reichstein wrote:
Make it
if (desc.isConfigurable()) {
...
}
instead of using continue. More readable, since it makes control flow
visible by
indentation.
Done.
http://codereview.chromium.org/7044104/diff/1/src/v8natives.js#newcode958
src/v8natives.js:958: if (!desc.isWritable() && !desc.isConfigurable())
continue;
On 2011/06/10 09:09:10, Lasse Reichstein wrote:
Ditto here: invert the condition and put the rest of the loop inside
the if. And
drop the tests before setting Writable and Configurable to false.
Done.
http://codereview.chromium.org/7044104/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
