LGTM, but maybe it could be even better:
http://codereview.chromium.org/7044100/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/7044100/diff/1/src/parser.cc#newcode2559 src/parser.cc:2559: if (value == 0) { Could this be something ala: Handle<Object> boolean(isolate->heap()->ToBoolean(value == 0)); return new(zone()) Literal(boolean); or perhaps consider negating the result of calling expression->AsLiteral()->handle()->ToBoolean() and refactoring the code so it works for cases where the expression is a non-numeric literal. http://codereview.chromium.org/7044100/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
