Reviewers: Mikhail Naganov (Chromium),
Message:
Hi Mikhail,
your last changes on the Thread class in src/platform.h resulted in making
d8
unable to compile since the constructor of Thread has a new signature. I
made a
few small changes to make it work again.
Cheers,
Yang
Description:
corrected parts in d8 that accesses the new "deisolated" Thread in
platform.h
BUG= d8 wouldn't compile with the new platform.h and the new constructor of
the
Thread class
TEST=
Please review this at http://codereview.chromium.org/7003113/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/d8-debug.h
M src/d8.cc
Index: src/d8-debug.h
diff --git a/src/d8-debug.h b/src/d8-debug.h
index
ceb9e363e0ed36578d2bb8bc854326bd18904691..90a9ce921e9c94dc6347fc99a2ca60a9b7f3fb22
100644
--- a/src/d8-debug.h
+++ b/src/d8-debug.h
@@ -99,7 +99,7 @@ class RemoteDebugger {
class ReceiverThread: public i::Thread {
public:
ReceiverThread(i::Isolate* isolate, RemoteDebugger* remote_debugger)
- : Thread(isolate, "d8:ReceiverThrd"),
+ : Thread("d8:ReceiverThrd"),
remote_debugger_(remote_debugger) {}
~ReceiverThread() {}
@@ -114,7 +114,7 @@ class ReceiverThread: public i::Thread {
class KeyboardThread: public i::Thread {
public:
explicit KeyboardThread(i::Isolate* isolate, RemoteDebugger*
remote_debugger)
- : Thread(isolate, "d8:KeyboardThrd"),
+ : Thread("d8:KeyboardThrd"),
remote_debugger_(remote_debugger) {}
~KeyboardThread() {}
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
022860ead8dcc68e03d6bd54d4d1907372c237e2..fe3bb2d6a4482e10d305d5ebdded3e84bafc6e10
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -772,7 +772,7 @@ void Shell::RunShell() {
class ShellThread : public i::Thread {
public:
ShellThread(i::Isolate* isolate, int no, i::Vector<const char> files)
- : Thread(isolate, "d8:ShellThread"),
+ : Thread("d8:ShellThread"),
no_(no), files_(files) { }
virtual void Run();
private:
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
