LGTM if you change the iterator interface slightly.
http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h#newcode802 src/hydrogen-instructions.h:802: bool HasNext() { return next_ < instr_->SuccessorCount(); } Most of the existing hydrogen/lithium iterators have changed to have the interface bool Done(); T* Current(); void Advance(); Could you change this one? http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h#newcode854 src/hydrogen-instructions.h:854: class HDeoptimize : public HControlInstruction { The rest of this file, with only a coupld of exceptions, doesn't have a space before ':' http://codereview.chromium.org/7114004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
