LGTM
http://codereview.chromium.org/7044082/diff/1/src/store-buffer.cc File src/store-buffer.cc (right): http://codereview.chromium.org/7044082/diff/1/src/store-buffer.cc#newcode407 src/store-buffer.cc:407: // TODO(gc) ISOLATES MERGE Let's just delete this comment. http://codereview.chromium.org/7044082/diff/1/src/store-buffer.cc#newcode575 src/store-buffer.cc:575: // May be invalid if object is not in new space. It may well be me that wrote this, but I can't remember any more why we can't just delete this comment and move the line below into the 'if'. http://codereview.chromium.org/7044082/diff/1/src/store-buffer.h File src/store-buffer.h (right): http://codereview.chromium.org/7044082/diff/1/src/store-buffer.h#newcode165 src/store-buffer.h:165: // All pages will be marked as having invalid watermark upon Given that we don't have watermarks any more, this comment should probably just be deleted. http://codereview.chromium.org/7044082/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
