http://codereview.chromium.org/7146010/diff/4/src/messages.js File src/messages.js (right):
http://codereview.chromium.org/7146010/diff/4/src/messages.js#newcode193 src/messages.js:193: define_disallowed: ["Cannot define property ", "%0", ", object is not extensible."], On 2011/06/14 11:17:15, Lasse Reichstein wrote:
':' after 'property' (or quotes around %0) to separate it from the
sentence. Done. http://codereview.chromium.org/7146010/diff/4/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/7146010/diff/4/src/v8natives.js#newcode632 src/v8natives.js:632: throw MakeTypeError("define_disallowed", [ToString(p)]); On 2011/06/14 11:17:15, Lasse Reichstein wrote:
Here 'p' is always a primitive, right?
Done and below (yes, we already always called ToString on this before calling this function) http://codereview.chromium.org/7146010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
