Comments addressed, please have another look
http://codereview.chromium.org/7149015/diff/7002/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7149015/diff/7002/src/runtime.cc#newcode4023 src/runtime.cc:4023: if (Handle<String>::cast(key)->AsArrayIndex(&index)) { On 2011/06/14 13:21:51, Erik Corry wrote:
There's a ton of copied code here. You could create a helper or just recurse: return
SetObjectProperty(isolate,
object, Smi::fromInt(index), value, attr, strict_mode);
Done. http://codereview.chromium.org/7149015/diff/7002/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/7149015/diff/7002/test/cctest/test-api.cc#newcode14497 test/cctest/test-api.cc:14497: obj->Set(v8_num(2), v8_str("foobar")); On 2011/06/14 13:21:51, Erik Corry wrote:
Can we haz a test with a string that represents an out-of-Smi-range
integer? Done. http://codereview.chromium.org/7149015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
