http://codereview.chromium.org/7149016/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right):
http://codereview.chromium.org/7149016/diff/1/src/incremental-marking.cc#newcode162 src/incremental-marking.cc:162: chunk->SetFlag(MemoryChunk::SCAN_ON_SCAVENGE); Keeping it. http://codereview.chromium.org/7149016/diff/1/src/incremental-marking.cc#newcode175 src/incremental-marking.cc:175: void IncrementalMarking::DeactivateWriteBarrierForSpace(NewSpace* space) { search-and-replaced. http://codereview.chromium.org/7149016/diff/1/src/incremental-marking.cc#newcode211 src/incremental-marking.cc:211: NewSpacePageIterator it(space->ToSpaceLow(), space->ToSpaceHigh()); Actually that's why I want a page iterator to iterate over the pages of the semispace without doing the book-keeping every time. http://codereview.chromium.org/7149016/diff/1/src/incremental-marking.cc#newcode211 src/incremental-marking.cc:211: NewSpacePageIterator it(space->ToSpaceLow(), space->ToSpaceHigh()); Changed to use NewSpacePageIterator(space), which does the same thing. http://codereview.chromium.org/7149016/diff/1/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7149016/diff/1/src/spaces.cc#newcode1006 src/spaces.cc:1006: if (new_limit < allocation_info_.limit) { Done. http://codereview.chromium.org/7149016/diff/1/src/spaces.cc#newcode1095 src/spaces.cc:1095: current = page->body(); The loop ends immediately after, so that won't make any difference. http://codereview.chromium.org/7149016/diff/1/src/spaces.cc#newcode1311 src/spaces.cc:1311: // on from-space pages, so it might be out of sync with the marking state. Yes, but why move complexity from debug-only code to "real" code. http://codereview.chromium.org/7149016/diff/1/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/7149016/diff/1/src/spaces.h#newcode1531 src/spaces.h:1531: static bool at_start(Address addr) { Done http://codereview.chromium.org/7149016/diff/1/src/spaces.h#newcode1536 src/spaces.h:1536: static bool at_end(Address addr) { do. http://codereview.chromium.org/7149016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
