Comments addressed, new patch will be uploaded soon.
http://codereview.chromium.org/7108061/diff/4001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/7108061/diff/4001/src/arm/assembler-arm.cc#newcode327 src/arm/assembler-arm.cc:327: first_const_pool_use_ = 0; On 2011/06/14 07:50:56, Søren Gjesse wrote:
Maybe initialize to -1, as the value is only valid when num_prinfo_ is 0.
Done. http://codereview.chromium.org/7108061/diff/4001/src/arm/assembler-arm.cc#newcode2589 src/arm/assembler-arm.cc:2589: // the constant pool is at least kMaxDistToPool / 2. On 2011/06/14 07:50:56, Søren Gjesse wrote:
And then add ASSERT(first_const_pool_use_ >= 0).
Done. http://codereview.chromium.org/7108061/diff/4001/src/arm/assembler-arm.cc#newcode2628 src/arm/assembler-arm.cc:2628: ASSERT(IsLdrPcImmediateOffset(instr) && (instr & kOff12Mask) == 0); Used GetLdrRegImmediateOffset which was already implemented. http://codereview.chromium.org/7108061/diff/4001/src/arm/assembler-arm.cc#newcode2637 src/arm/assembler-arm.cc:2637: instr_at_put(rinfo.pc(), instr + delta); Used SetLdrRegImmediateOffset which was already implemented. http://codereview.chromium.org/7108061/diff/4001/src/arm/assembler-arm.cc#newcode2642 src/arm/assembler-arm.cc:2642: first_const_pool_use_ = 0; On 2011/06/14 07:50:56, Søren Gjesse wrote:
0 -> -1?
Done. http://codereview.chromium.org/7108061/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
