Reviewers: Søren Gjesse,
Description:
MIPS: Update an outdated comment in the CEntryStub.
Following r8289 (bf0c0cf).
BUG=
TEST=
Please review this at http://codereview.chromium.org/7211007/
Affected files:
M src/mips/code-stubs-mips.cc
Index: src/mips/code-stubs-mips.cc
diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc
index
0ce551d7b3798eada3dd33f8765a082e04281c03..cc4f2a7e2dc4afcc1d905982550e1b20b84462ad
100644
--- a/src/mips/code-stubs-mips.cc
+++ b/src/mips/code-stubs-mips.cc
@@ -3542,15 +3542,10 @@ void CEntryStub::GenerateCore(MacroAssembler* masm,
__ li(a2, Operand(ExternalReference::isolate_address()));
- // From arm version of this function:
- // TODO(1242173): To let the GC traverse the return address of the exit
- // frames, we need to know where the return address is. Right now,
- // we push it on the stack to be able to find it again, but we never
- // restore from it in case of changes, which makes it impossible to
- // support moving the C entry code stub. This should be fixed, but
currently
- // this is OK because the CEntryStub gets generated so early in the V8
boot
- // sequence that it is not moving ever.
-
+ // To let the GC traverse the return address of the exit frames, we need
to
+ // know where the return address is. The CEntryStub is unmovable, so
+ // we can store the address on the stack to be able to find it again and
+ // we never have to restore it, because it will not change.
{ Assembler::BlockTrampolinePoolScope block_trampoline_pool(masm);
// This branch-and-link sequence is needed to find the current PC on
mips,
// saved to the ra register.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
