Drive by comments.

http://codereview.chromium.org/7230006/diff/6001/src/factory.cc
File src/factory.cc (right):

http://codereview.chromium.org/7230006/diff/6001/src/factory.cc#newcode220
src/factory.cc:220: CALL_HEAP_FUNCTION(isolate(),
Assert it's a strict substring?

http://codereview.chromium.org/7230006/diff/6001/src/json-parser.h
File src/json-parser.h (right):

http://codereview.chromium.org/7230006/diff/6001/src/json-parser.h#newcode371
src/json-parser.h:371: return Handle<Smi>(Smi::FromInt((negative ? -i :
i)));
Contains an implicit TLS load. Pass isolate as the second argument to
Handle ctor to avoid.

http://codereview.chromium.org/7230006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to