A bit more comments.
http://codereview.chromium.org/6995161/diff/1/src/gdb-jit.cc File src/gdb-jit.cc (right): http://codereview.chromium.org/6995161/diff/1/src/gdb-jit.cc#newcode1293 src/gdb-jit.cc:1293: int current_abbreviation = 4; Move it to the beginning of the function and use instead of 1, 2, 3 http://codereview.chromium.org/6995161/diff/1/src/gdb-jit.cc#newcode1318 src/gdb-jit.cc:1318: for (int context_slot = 0; context_slot < context_slots; for(x; y; z) http://codereview.chromium.org/6995161/diff/1/src/gdb-jit.cc#newcode1320 src/gdb-jit.cc:1320: w->WriteULEB128(current_abbreviation++); Seems to be duplicated. Extract to a method? http://codereview.chromium.org/6995161/diff/1/src/gdb-jit.cc#newcode1329 src/gdb-jit.cc:1329: for (int internal_slot = 0; internal_slot < internal_slots; for(x; y; z) http://codereview.chromium.org/6995161/diff/1/src/gdb-jit.cc#newcode1331 src/gdb-jit.cc:1331: w->WriteULEB128(current_abbreviation++); Seems to be duplicated. Extract to a method? Maybe extract the whole loop into method. http://codereview.chromium.org/6995161/diff/1/src/gdb-jit.cc#newcode1341 src/gdb-jit.cc:1341: w->WriteULEB128(current_abbreviation++); Partially duplicated. If possible try to unify with method extracted for the previous loops. http://codereview.chromium.org/6995161/diff/1/src/gdb-jit.cc#newcode1368 src/gdb-jit.cc:1368: w->WriteULEB128(current_abbreviation++); Duplicated? http://codereview.chromium.org/6995161/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
