http://codereview.chromium.org/7247002/diff/1/src/assembler.cc File src/assembler.cc (right):
http://codereview.chromium.org/7247002/diff/1/src/assembler.cc#newcode101 src/assembler.cc:101: fixed. http://codereview.chromium.org/7247002/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/7247002/diff/1/src/ia32/macro-assembler-ia32.cc#newcode2419 src/ia32/macro-assembler-ia32.cc:2419: test_b(Operand(instance_type), kExternalStringTag); Added assert. Are we sure it's not more used in the browser? http://codereview.chromium.org/7247002/diff/1/src/ia32/macro-assembler-ia32.cc#newcode2423 src/ia32/macro-assembler-ia32.cc:2423: bind(¬_external); added http://codereview.chromium.org/7247002/diff/1/src/ia32/macro-assembler-ia32.cc#newcode2432 src/ia32/macro-assembler-ia32.cc:2432: ASSERT_EQ(SeqAsciiString::kMaxSize, SeqAsciiString::kMaxSize); *Cough* Fixed. http://codereview.chromium.org/7247002/diff/1/src/ia32/macro-assembler-ia32.cc#newcode2448 src/ia32/macro-assembler-ia32.cc:2448: add(Operand(bitmap_scratch, MemoryChunk::kLiveBytesOffset), Possibly a few cycle slower latency (but we're most likely not going to read it in the next few cycles anyway), should be outweighed by the smaller code. http://codereview.chromium.org/7247002/diff/1/src/ia32/macro-assembler-ia32.h File src/ia32/macro-assembler-ia32.h (right): http://codereview.chromium.org/7247002/diff/1/src/ia32/macro-assembler-ia32.h#newcode799 src/ia32/macro-assembler-ia32.h:799: // unchanged, unless it's also mask_reg. Ack, forgot to change comment back when I reverted my change to the function. http://codereview.chromium.org/7247002/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/7247002/diff/1/src/ia32/stub-cache-ia32.cc#newcode1549 src/ia32/stub-cache-ia32.cc:1549: // TODO(gc): This only happen in new-space, where we don't Done. http://codereview.chromium.org/7247002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/7247002/diff/1/src/mark-compact.cc#newcode317 src/mark-compact.cc:317: if (old_start == new_start) return false; done. http://codereview.chromium.org/7247002/diff/1/src/mark-compact.h File src/mark-compact.h (right): http://codereview.chromium.org/7247002/diff/1/src/mark-compact.h#newcode122 src/mark-compact.h:122: // Returns true if the new_start is marked black. Done. http://codereview.chromium.org/7247002/diff/1/src/mark-compact.h#newcode155 src/mark-compact.h:155: Fixed. http://codereview.chromium.org/7247002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
