Revision: 8411
Author: [email protected]
Date: Fri Jun 24 05:04:14 2011
Log: Fix three GC unsafe places found by gcmole's dead_vars analysis.
Review URL: http://codereview.chromium.org/7247013
http://code.google.com/p/v8/source/detail?r=8411
Modified:
/branches/bleeding_edge/src/objects.cc
=======================================
--- /branches/bleeding_edge/src/objects.cc Thu Jun 23 04:22:21 2011
+++ /branches/bleeding_edge/src/objects.cc Fri Jun 24 05:04:14 2011
@@ -2233,7 +2233,7 @@
Execution::Call(trap, handler, ARRAY_SIZE(args), args,
&has_exception);
if (has_exception) return Failure::Exception();
- return value_raw;
+ return *value;
}
@@ -3065,8 +3065,9 @@
// In strict mode, attempting to delete a non-configurable property
// throws an exception.
HandleScope scope(isolate);
+ Handle<Object> holder(this);
Handle<Object> name = isolate->factory()->NewNumberFromUint(index);
- Handle<Object> args[2] = { name, Handle<Object>(this) };
+ Handle<Object> args[2] = { name, holder };
Handle<Object> error =
isolate->factory()->NewTypeError("strict_delete_property",
HandleVector(args, 2));
@@ -8334,8 +8335,8 @@
dictionary->UpdateMaxNumberKey(index);
// If put fails in strict mode, throw an exception.
if (!dictionary->ValueAtPut(entry, value) && strict_mode ==
kStrictMode) {
- Handle<Object> number =
isolate->factory()->NewNumberFromUint(index);
Handle<Object> holder(this);
+ Handle<Object> number =
isolate->factory()->NewNumberFromUint(index);
Handle<Object> args[2] = { number, holder };
Handle<Object> error =
isolate->factory()->NewTypeError("strict_read_only_property",
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
