You can put a // NOLINT comment to avoid the presubmit warning. On Sat, Jun 25, 2011 at 9:31 PM, <[email protected]> wrote: > There are good tests in array-sort, but I think they miss some cases > (max-smi, > min-smi). I'll extend the tests. > > What should I do about this presubmit warning? > I can't change long to some other type because it is passed by pointer, and > that > is what the headers define the intrinsic as taking. > > > http://codereview.chromium.org/7261008/diff/1/src/misc-intrinsics.h > File src/misc-intrinsics.h (right): > > http://codereview.chromium.org/7261008/diff/1/src/misc-intrinsics.h#newcode42 > src/misc-intrinsics.h:42: } } // namespace v8::internal > On 2011/06/25 11:12:03, Erik Corry wrote: >> >> Instead of closing the name space here and then using explicit name > > spaces on >> >> the definitions below you can just close it at the end. > > Done. Originally I was expecting to have to #include other files, like > atomicops. > > http://codereview.chromium.org/7261008/diff/1/src/runtime.cc > File src/runtime.cc (right): > > http://codereview.chromium.org/7261008/diff/1/src/runtime.cc#newcode6665 > src/runtime.cc:6665: static const int powersOf10[] = { 1, 10, 100, 1000, > 10*1000, 100*1000, > On 2011/06/25 11:12:03, Erik Corry wrote: >> >> This is a constant so it should be named as a constant: kPowersOf10. >> Also, the indentation is wrong. Newline-after { is the norm in the > > rest of the >> >> code base and } gets its own line. > > Done. > > http://codereview.chromium.org/7261008/ >
-- Erik Corry, Software Engineer Google Denmark ApS - Frederiksborggade 20B, 1 sal, 1360 København K - Denmark - CVR nr. 28 86 69 84 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
