Reviewers: Rico,
Description:
Ensure 16-byte stack alignment on Solaris.
GCC generates instructions such as movdqa that requires 16-byte alignment.
[email protected]
BUG=v8:1505
TEST=
Please review this at http://codereview.chromium.org/7277031/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M ChangeLog
M src/platform-solaris.cc
Index: ChangeLog
diff --git a/ChangeLog b/ChangeLog
index
b3f589d852c38d9183acff1207c6f5e37fafdbd9..775983f82d224369b7c133940fd42ed650858261
100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -13,10 +13,10 @@
Lowered limit on code space for systems with low memory supply.
Allowed compiling v8_shell with the 'host' toolset (issue 82437).
-
+
Extended setBreakpoint API to accept partial script name (issue
1418).
- Made multi-line comments not count when deciding whether the '-->'
+ Made multi-line comments not count when deciding whether the '-->'
comment starter is first on a line. This matches Safari.
Made handling of non-array recievers in Array length setter correct
Index: src/platform-solaris.cc
diff --git a/src/platform-solaris.cc b/src/platform-solaris.cc
index
b8124910be1a38a1dcc24f7863c892c5984439fb..1d1e73347dfb16e1e53dbcabe1ca31f14d2067c1
100644
--- a/src/platform-solaris.cc
+++ b/src/platform-solaris.cc
@@ -1,4 +1,4 @@
-// Copyright 2006-2009 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -105,7 +105,8 @@ uint64_t OS::CpuFeaturesImpliedByPlatform() {
int OS::ActivationFrameAlignment() {
- return STACK_ALIGN;
+ // GCC generate code that requires 16 byte alignment such as movdqa.
+ return Max(STACK_ALIGN, 16);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
