Revision: 8432
Author:   [email protected]
Date:     Tue Jun 28 00:07:09 2011
Log:      Ensure 16-byte stack alignment on Solaris.

GCC generates instructions such as movdqa that requires 16-byte alignment.

[email protected]
BUG=v8:1505
TEST=

Review URL: http://codereview.chromium.org/7277031
http://code.google.com/p/v8/source/detail?r=8432

Modified:
 /branches/bleeding_edge/ChangeLog
 /branches/bleeding_edge/src/platform-solaris.cc

=======================================
--- /branches/bleeding_edge/ChangeLog   Mon Jun 27 06:16:07 2011
+++ /branches/bleeding_edge/ChangeLog   Tue Jun 28 00:07:09 2011
@@ -13,10 +13,10 @@
         Lowered limit on code space for systems with low memory supply.

         Allowed compiling v8_shell with the 'host' toolset (issue 82437).
-
+
Extended setBreakpoint API to accept partial script name (issue 1418).

-        Made multi-line comments not count when deciding whether the '-->'
+        Made multi-line comments not count when deciding whether the '-->'
         comment starter is first on a line. This matches Safari.

         Made handling of non-array recievers in Array length setter correct
=======================================
--- /branches/bleeding_edge/src/platform-solaris.cc     Fri Jun 10 02:54:04 2011
+++ /branches/bleeding_edge/src/platform-solaris.cc     Tue Jun 28 00:07:09 2011
@@ -1,4 +1,4 @@
-// Copyright 2006-2009 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
@@ -105,7 +105,8 @@


 int OS::ActivationFrameAlignment() {
-  return STACK_ALIGN;
+  // GCC generates code that requires 16 byte alignment such as movdqa.
+  return Max(STACK_ALIGN, 16);
 }


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to