Revision: 8434 Author: [email protected] Date: Tue Jun 28 00:54:01 2011 Log: MIPS: port Fix receiver check in arguments ICs.
Ported r8429 (60a2787) BUG= TEST= Review URL: http://codereview.chromium.org//7276027 Patch from Paul Lind <[email protected]>. http://code.google.com/p/v8/source/detail?r=8434 Modified: /branches/bleeding_edge/src/mips/ic-mips.cc ======================================= --- /branches/bleeding_edge/src/mips/ic-mips.cc Mon Jun 27 01:56:25 2011 +++ /branches/bleeding_edge/src/mips/ic-mips.cc Tue Jun 28 00:54:01 2011 @@ -903,8 +903,13 @@ Label* slow_case) { Heap* heap = masm->isolate()->heap(); - // Check that the receiver isn't a smi. + // Check that the receiver is a JSObject. Because of the map check + // later, we do not need to check for interceptors or whether it + // requires access checks. __ JumpIfSmi(object, slow_case); + // Check that the object is some kind of JSObject. + __ GetObjectType(object, scratch1, scratch2); + __ Branch(slow_case, lt, scratch2, Operand(FIRST_JS_RECEIVER_TYPE)); // Check that the key is a positive smi. __ And(scratch1, key, Operand(0x8000001)); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
