Reviewers: Søren Gjesse, mads.ager,
Message:
I modified test.py to include the --test option when using d8 as shell.
I got the following "benchmark" for the unit tests on my z600
sample shell, -j16:
[00:32|% 100|+ 6150|- 0]: Done
real 0m43.591s
user 6m18.650s
sys 0m49.580s
D8 without --test, -j16
[00:33|% 100|+ 6150|- 0]: Done
real 0m44.501s
user 6m18.220s
sys 0m52.250s
D8 with --test, -j16
[00:33|% 100|+ 6150|- 0]: Done
real 0m44.171s
user 6m15.100s
sys 0m51.660s
So using D8 with --test makes unit test take half a second longer. We can
consider using D8 to replace the sample shell now.
Cheers,
Yang
http://codereview.chromium.org/7272028/diff/1/tools/test.py
File tools/test.py (right):
http://codereview.chromium.org/7272028/diff/1/tools/test.py#newcode1275
tools/test.py:1275: if options.shell == "d8":
when using d8 as shell, include "--test" as command line option.
Description:
added the --test option for d8 into tools/test.py
TEST= tools/test.py --shell d8 -v
Please review this at http://codereview.chromium.org/7272028/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/test.py
Index: tools/test.py
diff --git a/tools/test.py b/tools/test.py
index
cb2428cab852892c1eaa0e89106e1032e76fc723..d09f275e5be2ee374416bc12bf5052d36288b550
100755
--- a/tools/test.py
+++ b/tools/test.py
@@ -1272,6 +1272,11 @@ def ProcessOptions(options):
options.special_command += " --crankshaft"
else:
options.special_command = "@--crankshaft"
+ if options.shell == "d8":
+ if options.special_command:
+ options.special_command += " --test"
+ else:
+ options.special_command = "@--test"
if options.noprof:
options.scons_flags.append("prof=off")
options.scons_flags.append("profilingsupport=off")
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
