Reviewers: Kasper Lund, Mads Ager,
Message:
I'm trying to understand some parts of Crankshaft, and I figure that if
I decide that something is crufty it's better to go ahead and push a fix
than make a note. Please let me know if you would rather receive these
patches in some other manner, or not at all.
Description:
--trace_hydrogen cleanup
* src/hydrogen.cc (HTracer::Trace): Remove from_bci and to_bci
printouts (always -1), xhandlers and flags (always empty), and the bci
column for instruction traces (always 0).
BUG=
TEST=
Please review this at http://codereview.chromium.org/7273033/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
38676624c618eeb3fa19fb257c75d37c3191c186..ae3a15f18f59866ebc5680b93167bbbe01ec5a40
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -6302,8 +6302,6 @@ void HTracer::Trace(const char* name, HGraph* graph,
LChunk* chunk) {
HBasicBlock* current = blocks->at(i);
Tag block_tag(this, "block");
PrintBlockProperty("name", current->block_id());
- PrintIntProperty("from_bci", -1);
- PrintIntProperty("to_bci", -1);
if (!current->predecessors()->is_empty()) {
PrintIndent();
@@ -6327,9 +6325,6 @@ void HTracer::Trace(const char* name, HGraph* graph,
LChunk* chunk) {
trace_.Add("\n");
}
- PrintEmptyProperty("xhandlers");
- PrintEmptyProperty("flags");
-
if (current->dominator() != NULL) {
PrintBlockProperty("dominator", current->dominator()->block_id());
}
@@ -6366,10 +6361,9 @@ void HTracer::Trace(const char* name, HGraph* graph,
LChunk* chunk) {
Tag HIR_tag(this, "HIR");
HInstruction* instruction = current->first();
while (instruction != NULL) {
- int bci = 0;
int uses = instruction->UseCount();
PrintIndent();
- trace_.Add("%d %d ", bci, uses);
+ trace_.Add("%d ", uses);
instruction->PrintNameTo(&trace_);
trace_.Add(" ");
instruction->PrintTo(&trace_);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
