LGTM too
http://codereview.chromium.org/7230047/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/7230047/diff/1/src/arm/full-codegen-arm.cc#newcode1872 src/arm/full-codegen-arm.cc:1872: case Slot::CONTEXT: On 2011/06/28 14:37:48, Kevin Millikin wrote:
Const initialization can be nested inside a with or catch, but with
our current
semantics they are hoisted.
We could implement the loop up the context chain in generated code
(even unroll
the loop once the chain length is known statically), but I've opted to
just call
the runtime.
Let's file a bug report (internal cleanup?) about investigating the impact of native code implementation of this to not forget. Context stores could be quite frequent and this would slow it down quite a bit. http://codereview.chromium.org/7230047/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
