Reviewers: jkummerow,
Message:
like we discussed. the reverting patch to mimic a rollback.
thanks.
Description:
reverting revision r8454
Please review this at http://codereview.chromium.org/7218042/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/d8.h
M src/d8.cc
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
7d16ec34731607261dc5f0487c9e580b1f45a85e..7655aad4b53dfefc4f19bc3fb15d7cea965dd098
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -599,36 +599,10 @@ Handle<ObjectTemplate> Shell::CreateGlobalTemplate() {
AddOSMethods(os_templ);
global_template->Set(String::New("os"), os_templ);
- Handle<ObjectTemplate> counter_templ = ObjectTemplate::New();
- counter_templ->Set(String::New("get"),
- FunctionTemplate::New(CounterGetValue));
- global_template->Set(String::New("counter"), counter_templ);
-
return global_template;
}
-Handle<Value> Shell::CounterGetValue(const Arguments& args){
- if (args.Length() != 1) {
- return ThrowException(String::New("get() takes one argument"));
- }
- if (args[0]->IsString()) {
- String::AsciiValue name(args[0]);
- Counter* counter = counter_map_->Lookup(*name);
- if (!counter) {
- String::AsciiValue prefixed(String::Concat(String::New("c:"),
- String::New(*name)));
- counter = counter_map_->Lookup(*prefixed);
- if (!counter) {
- return ThrowException(String::New("invalid counter name"));
- }
- }
- return Handle<Integer>::Cast(Integer::New(counter->count()));
- }
- return ThrowException(String::New("counter name must be a string"));
-}
-
-
void Shell::Initialize(bool test_shell) {
#ifdef COMPRESS_STARTUP_DATA_BZ2
BZip2Decompressor startup_data_decompressor;
Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index
4a82c0becfc21f63f2559dfa892694c191b6c44c..f3760e8bc8ed37f8b7a81db557276bf131bf805c
100644
--- a/src/d8.h
+++ b/src/d8.h
@@ -128,7 +128,6 @@ class Shell: public i::AllStatic {
size_t buckets);
static void AddHistogramSample(void* histogram, int sample);
static void MapCounters(const char* name);
- static Handle<Value> CounterGetValue(const Arguments& args);
static Handle<String> ReadFile(const char* name);
static void Initialize(bool test_shell);
static void RenewEvaluationContext();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
