Revision: 8457 Author: [email protected] Date: Wed Jun 29 01:45:22 2011 Log: reverting revision r8454
Review URL: http://codereview.chromium.org/7218042 http://code.google.com/p/v8/source/detail?r=8457 Modified: /branches/bleeding_edge/src/d8.cc /branches/bleeding_edge/src/d8.h ======================================= --- /branches/bleeding_edge/src/d8.cc Wed Jun 29 01:22:36 2011 +++ /branches/bleeding_edge/src/d8.cc Wed Jun 29 01:45:22 2011 @@ -599,34 +599,8 @@ AddOSMethods(os_templ); global_template->Set(String::New("os"), os_templ); - Handle<ObjectTemplate> counter_templ = ObjectTemplate::New(); - counter_templ->Set(String::New("get"), - FunctionTemplate::New(CounterGetValue)); - global_template->Set(String::New("counter"), counter_templ); - return global_template; } - - -Handle<Value> Shell::CounterGetValue(const Arguments& args){ - if (args.Length() != 1) { - return ThrowException(String::New("get() takes one argument")); - } - if (args[0]->IsString()) { - String::AsciiValue name(args[0]); - Counter* counter = counter_map_->Lookup(*name); - if (!counter) { - String::AsciiValue prefixed(String::Concat(String::New("c:"), - String::New(*name))); - counter = counter_map_->Lookup(*prefixed); - if (!counter) { - return ThrowException(String::New("invalid counter name")); - } - } - return Handle<Integer>::Cast(Integer::New(counter->count())); - } - return ThrowException(String::New("counter name must be a string")); -} void Shell::Initialize(bool test_shell) { ======================================= --- /branches/bleeding_edge/src/d8.h Wed Jun 29 01:22:36 2011 +++ /branches/bleeding_edge/src/d8.h Wed Jun 29 01:45:22 2011 @@ -128,7 +128,6 @@ size_t buckets); static void AddHistogramSample(void* histogram, int sample); static void MapCounters(const char* name); - static Handle<Value> CounterGetValue(const Arguments& args); static Handle<String> ReadFile(const char* name); static void Initialize(bool test_shell); static void RenewEvaluationContext(); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
