LGTM
http://codereview.chromium.org/7268002/diff/1/samples/shell.cc File samples/shell.cc (right): http://codereview.chromium.org/7268002/diff/1/samples/shell.cc#newcode505 samples/shell.cc:505: if (args[0]->Int32Value() < 0) { An unsigned long can take values that are too big (e.g., 2^32), and which get silently truncated by converting to ToInt32, so I think you should do the range testing before converting. http://codereview.chromium.org/7268002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
