http://codereview.chromium.org/7277038/diff/1/src/heap.h File src/heap.h (right):
http://codereview.chromium.org/7277038/diff/1/src/heap.h#newcode241 src/heap.h:241: static bool ConfigureHeap(int max_semispace_size, The fields are ints, so passing something bigger here won't help anyway. If anything, requiring ints to be passed will avoid silently eating overflows. We should probably convert them all to intptr_t, but that's a larger change. http://codereview.chromium.org/7277038/diff/1/src/platform-win32.cc File src/platform-win32.cc (right): http://codereview.chromium.org/7277038/diff/1/src/platform-win32.cc#newcode1415 src/platform-win32.cc:1415: return VirtualFree(address, size, MEM_DECOMMIT) != false; Doesn't seem any shorter, but perhaps a little cleaner. I'll change them. http://codereview.chromium.org/7277038/diff/1/src/x64/macro-assembler-x64.h File src/x64/macro-assembler-x64.h (right): http://codereview.chromium.org/7277038/diff/1/src/x64/macro-assembler-x64.h#newcode81 src/x64/macro-assembler-x64.h:81: // --------------------------------------------------------------------------- Deliberate. No need to indent the separator. http://codereview.chromium.org/7277038/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
