Revision: 8463
Author: [email protected]
Date: Wed Jun 29 04:36:32 2011
Log: Fix bug in semispace shrink-to.
Review URL: http://codereview.chromium.org/7281006
http://code.google.com/p/v8/source/detail?r=8463
Modified:
/branches/experimental/gc/src/spaces.cc
=======================================
--- /branches/experimental/gc/src/spaces.cc Fri Jun 24 05:46:32 2011
+++ /branches/experimental/gc/src/spaces.cc Wed Jun 29 04:36:32 2011
@@ -1222,18 +1222,21 @@
ASSERT((new_capacity & Page::kPageAlignmentMask) == 0);
ASSERT(new_capacity >= initial_capacity_);
ASSERT(new_capacity < capacity_);
- Address end = start_ + maximum_capacity_;
- Address start = end - new_capacity;
+ // Semispaces grow backwards from the end of their allocated capacity,
+ // so we find the before and after start addresses relative to the
+ // end of the space.
+ Address space_end = start_ + maximum_capacity_;
+ Address old_start = space_end - capacity_;
size_t delta = capacity_ - new_capacity;
ASSERT(IsAligned(delta, OS::AllocateAlignment()));
- if (!heap()->isolate()->memory_allocator()->UncommitBlock(start, delta))
{
+ if (!heap()->isolate()->memory_allocator()->UncommitBlock(old_start,
delta)) {
return false;
}
capacity_ = new_capacity;
int pages_after = capacity_ / Page::kPageSize;
NewSpacePage* new_last_page =
- NewSpacePage::FromAddress(end - pages_after * Page::kPageSize);
+ NewSpacePage::FromAddress(space_end - pages_after * Page::kPageSize);
new_last_page->set_next_page(anchor());
anchor()->set_prev_page(new_last_page);
ASSERT(current_page_ == first_page());
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
