http://codereview.chromium.org/7273066/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/7273066/diff/1/src/arm/full-codegen-arm.cc#newcode865 src/arm/full-codegen-arm.cc:865: EmitCallIC(ic, RelocInfo::CODE_TARGET, clause->CompareId()); I'd still prefer statically helping to never forget emitting the patch info. Dynamically checking with ASSERT only works for debug mode, and only if our tests hit all the places. That's why the parameter was introduced. Plus there is an extra line at each call site. http://codereview.chromium.org/7273066/diff/1/src/arm/full-codegen-arm.cc#newcode4203 src/arm/full-codegen-arm.cc:4203: if (StatsCounter* counter = ic->Counter(isolate())) { Do we really need those counters at all? We don't count loads/stores in Crankshaft generated code, so I think they aren't very useful anymore. Maybe we should just get rid of them. http://codereview.chromium.org/7273066/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
