Reviewers: Rico,
Description:
Temporarily add more test output to help locate test failure
[email protected]
BUG=none
TEST=none
Please review this at http://codereview.chromium.org/7250002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/disasm-arm.cc
M test/cctest/test-compiler.cc
Index: src/arm/disasm-arm.cc
diff --git a/src/arm/disasm-arm.cc b/src/arm/disasm-arm.cc
index
d4bd81ce464c9c5a7576f6a18f24a94e02cc41ba..673fe694c191500c708638bcaba0d9218919b3a4
100644
--- a/src/arm/disasm-arm.cc
+++ b/src/arm/disasm-arm.cc
@@ -992,6 +992,7 @@ void Decoder::DecodeType3(Instruction* instr) {
Format(instr, "bfi'cond 'rd, 'rm, 'f");
}
} else {
+ PrintF("%08x\n", instr->InstructionBits());
UNREACHABLE();
}
} else {
Index: test/cctest/test-compiler.cc
diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc
index
4c5f197bc649837efbf025e9a9f4987120e13f0d..380d6d95ce78f1fefcaaf9f9735f071b46eeb2d5
100644
--- a/test/cctest/test-compiler.cc
+++ b/test/cctest/test-compiler.cc
@@ -367,6 +367,9 @@ static void
CheckCodeForUnsafeLiteral(Handle<JSFunction> f) {
disasm::Disassembler d(name_converter);
if (f->code()->kind() == Code::FUNCTION) {
+#ifdef DEBUG
+ f->code()->PrintLn();
+#endif
Address pc = f->code()->instruction_start();
int decode_size =
Min(f->code()->instruction_size(),
@@ -375,6 +378,7 @@ static void
CheckCodeForUnsafeLiteral(Handle<JSFunction> f) {
v8::internal::EmbeddedVector<char, 128> decode_buffer;
while (pc < end) {
+ PrintF("%08x\n", reinterpret_cast<intptr_t>(pc));
pc += d.InstructionDecode(decode_buffer, pc);
CHECK(strstr(decode_buffer.start(), "mov eax,0x178c29c") == NULL);
CHECK(strstr(decode_buffer.start(), "push 0x178c29c") == NULL);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
